Upgrade all third-party actions and pin them to immutable releases#1038
Merged
Conversation
jeancochrane
changed the title
Agent-Logs-Url: https://github.com/ccao-data/data-architecture/sessions/f78a9f19-9aef-4fd0-88ab-c07fa0ddbfaa Co-authored-by: jeancochrane <14170650+jeancochrane@users.noreply.github.com>
…ectness in `lint.yaml`
jeancochrane
had a problem deploying
to
github-pages
GitHub Actions
Failure
Comment on lines
40
to
+60
| @@ -47,8 +47,16 @@ jobs: | |||
| VALIDATE_PYTHON_PYLINT: false | |||
| VALIDATE_PYTHON_RUFF: false | |||
| VALIDATE_R: false | |||
| VALIDATE_TRIVY: false | |||
| VALIDATE_GITHUB_ACTIONS_ZIZMOR: false | |||
| VALIDATE_BIOME_FORMAT: false | |||
| VALIDATE_BIOME_LINT: false | |||
| # The natural language check slows down our velocity and is rarely | |||
| # helpful | |||
| VALIDATE_NATURAL_LANGUAGE: false | |||
| # We use yamllint for YAML linting so we don't need prettier | |||
| VALIDATE_YAML_PRETTIER: false | |||
| # We have a separate workflow for pre-commit | |||
| VALIDATE_PRE_COMMIT: false | |||
Member
There was a problem hiding this comment.
Upgrading super-linter required handling a bunch of new linters they've added. I've disabled the ones that don't interest me. Feel free to push back if you like the looks of any of them (namely Trivy, Zizmor, and Biome).
jeancochrane
requested review from
jeancochrane and
wrridgeway
and removed request for
jeancochrane
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades all of our third-party GitHub Actions to ensure they are compatible with the upcoming Node 20 deprecation.
While we're at it, we also switch all of our references to third-party actions to point to immutable releases, so as to protect ourselves from the the ongoing scourge of supply chain attacks against third-party actions. If an action repo is using immutable releases, we pin to a specific immutable release; otherwise, we pin to the commit hash for the latest release of that action.
Test workflows to confirm these upgrades don't break anything:
upload-open-data-assets: https://github.com/ccao-data/data-architecture/actions/runs/26595839779/job/78366375418build-and-test-dbt: https://github.com/ccao-data/data-architecture/actions/runs/26586883031/job/78335161216build-daily-dbt-models: https://github.com/ccao-data/data-architecture/actions/runs/26587225036/job/78336387935cleanup-dbt-resourcesdeploy-dbt-docs: https://github.com/ccao-data/data-architecture/actions/runs/26587267545/job/78336872374pre-commit: https://github.com/ccao-data/data-architecture/actions/runs/26586882931/job/78335160507super-linter: https://github.com/ccao-data/data-architecture/actions/runs/26586882935/job/78335160470test-dbt-models: https://github.com/ccao-data/data-architecture/actions/runs/26587680018/job/78337998683test-dbt-source-freshness: https://github.com/ccao-data/data-architecture/actions/runs/26587729786/job/78338173538test-iasworld-data: https://github.com/ccao-data/data-architecture/actions/runs/26587804467/job/78338435413test-open-data-assets: https://github.com/ccao-data/data-architecture/actions/runs/26587829724/job/78338525270Connects https://github.com/ccao-data/aws-infrastructure/issues/59.