Skip to content

Harden release version wiring#141

Merged
cbusillo merged 1 commit into
mainfrom
fix/release-version-wiring
Jun 7, 2026
Merged

Harden release version wiring#141
cbusillo merged 1 commit into
mainfrom
fix/release-version-wiring

Conversation

@cbusillo
Copy link
Copy Markdown
Owner

@cbusillo cbusillo commented Jun 7, 2026

Summary

  • wait for App Store Connect builds to become visible and VALID before review submission
  • harden App Store review/version scans with pagination and READY_FOR_REVIEW handling
  • pass the resolved build number through Ship -> Release -> package-native and stamp bundle versions
  • preserve explicit App Store build numbers by removing Xcode auto build-number management
  • add release workflow/script regression tests

Validation

  • python3 -m unittest discover Tests/ScriptsTests
  • python3 -m py_compile scripts/submit-app-store-review.py Tests/ScriptsTests/test_submit_app_store_review.py Tests/ScriptsTests/test_release_workflows.py
  • shfmt -d scripts/package-native-macos-app.sh scripts/upload-testflight-macos-app.sh
  • actionlint .github/workflows/ship.yml .github/workflows/release.yml .github/workflows/submit-app-store-review.yml .github/workflows/testflight.yml
  • git diff --check
  • swift test

Review

  • Claude reviewed the original release workflow issue set and found stale READY_FOR_REVIEW/pagination/build-number risks.
  • Gemini/Antigravity independently identified the App Store build-processing race and GitHub Release bundle-stamping gap.
  • Claude reviewed the final diff; no blocking issues remained.

@cbusillo cbusillo merged commit ec265e8 into main Jun 7, 2026
3 checks passed
@cbusillo cbusillo deleted the fix/release-version-wiring branch June 7, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant