Validate App Store review dry-run version state#138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PENDING_DEVELOPER_RELEASEContext
The first actual 1.0.18 review submission failed after a successful dry-run with App Store Connect returning a 409
ENTITY_ERROR.RELATIONSHIP.INVALID/ "You cannot create a new version of the App in the current state." This patch closes that false-positive dry-run path.Validation
python3 -m unittest Tests/ScriptsTests/test_submit_app_store_review.py(24 tests)scripts/commit-gate.sh(258 Swift tests)git diff --checkpython3 -m py_compile scripts/submit-app-store-review.py Tests/ScriptsTests/test_submit_app_store_review.py