Skip to content

fix: remove nested split-button trigger wrapper#74

Merged
cbulock merged 1 commit into
mainfrom
zeno/split-button-a11y-fix
Jul 1, 2026
Merged

fix: remove nested split-button trigger wrapper#74
cbulock merged 1 commit into
mainfrom
zeno/split-button-a11y-fix

Conversation

@zeno-codebot

Copy link
Copy Markdown
Collaborator

Summary

  • remove the split-button <details><summary> wrapper so the menu trigger is no longer nested inside another interactive element
  • render the secondary trigger as a standalone cindor-button inside a non-interactive .menu-shell while preserving menu state, ARIA wiring, and Escape focus restoration
  • update split-button tests to target the standalone trigger and assert that no summary or details element is rendered

Verification

  • npm run test -- --run packages/core/src/components/split-button/cindor-split-button.test.ts
  • npm exec -- eslint packages/core/src/components/split-button/cindor-split-button.ts packages/core/src/components/split-button/cindor-split-button.test.ts

Notes

  • scoped to split-button and directly related tests only

@cbulock cbulock merged commit e07775c into main Jul 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants