fix(logging): cap the external aioice per-packet loggers too; 0.11.10#123
Merged
Conversation
0.11.7 capped the vendored aiortc RTP receiver/sender loggers, but aioice (the ICE/STUN library - a real dependency, not vendored) logs every STUN/TURN packet at DEBUG, so an active WebRTC connection still flooded the log when aidot DEBUG was enabled (on a microSD HA host this log I/O can starve the recorder). Cap aioice.ice and aioice.turn at INFO in the package init, same NOTSET-guarded pattern; useful ICE connection-state DEBUG still flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.11.7 log-flood cap only covered the vendored aiortc RTP receiver/sender loggers. The external
aioicepackage (a real dependency, not vendored) logs every STUN/TURN packet at DEBUG on its ownaioice.ice/aioice.turnloggers, so enabling DEBUG on the parentaidotlogger still unleashed a per-packet firehose from aioice.This extends the NOTSET-guarded cap in
aidot/__init__.pyto includeaioice.iceandaioice.turn, so DEBUG onaidotstays diagnostically useful (DTLS, SCTP/DCEP, ICE state still flow) without the packet flood that can starve the recorder on a microSD host. An explicit user-set level still wins.Tests updated:
tests/test_logging_caps.pynow asserts all four loggers are capped and thataidotDEBUG does not re-enable per-packet DEBUG.