fix(camera): quiet NO_MEDIA ffmpeg stderr so a dead camera stops spamming; 0.11.9#122
Merged
Merged
Conversation
…ps spamming; 0.11.9 An SDES camera whose SRTP never arrives (e.g. media not traversing the TURN relay) completes signaling, ffmpeg starts, then times out with an empty output - and SdesSession.stop() logged that stderr at WARNING on every serve retry, so a persistently-NO_MEDIA camera (observed live on an A001064 PTZ) filled the log. Route the stderr through _log_ffmpeg_stderr(), which logs at debug when no media was ever received (last_media_monotonic == 0) and keeps WARNING when media was flowing (a genuine mid-stream error).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SDES camera whose SRTP never arrives (e.g. media not traversing the TURN relay - observed live on an A001064 PTZ) completes signaling, ffmpeg starts, then times out with empty output, and SdesSession.stop() logged that stderr at WARNING on every serve retry, filling the log. _log_ffmpeg_stderr() now logs at debug ONLY when no media arrived AND the stderr is the expected empty-output shape; a genuine ffmpeg error (media was flowing, or an unexpected no-media failure) still warns. Code-reviewed (high effort); the media-only gate was refined to avoid hiding real ffmpeg errors. 313 tests.