fix(camera): quiet open-failure warnings for cloud-offline cameras; 0.11.8#121
Merged
Merged
Conversation
…ne; 0.11.8 The serve/keepalive loops already throttle open retries for a cloud-offline device (offline pause), but logged every failed probe at WARNING - so a dead/unpowered camera dripped 'open failed (retry ...)' warnings. Route those three open-failure logs through _open_fail_logger(), which returns DEBUG while the cloud has explicitly reported the device offline and WARNING otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dead/unpowered camera (cloud reports offline) is already throttled to probe cadence by the offline pause, but each failed probe still logged at WARNING. The three serve/keepalive open-failure logs now route through _open_fail_logger(): DEBUG while explicitly cloud-offline, WARNING otherwise. Unit-tested; 309 pass.