fix(camera): stop blocking the loop on sprop read; cap aiortc log flood; 0.11.7#120
Merged
Merged
Conversation
…tc packet log flood - The SDES SDP builder read the sprop cache (_inject_sprop -> _load_sprop -> open()) as an eager argument to run_in_executor, so the blocking open() ran on the event loop (HA flags it as causing stability issues). Move the read inside the executor at all three SDP-write sites. - Cap the vendored aiortc RTP receiver/sender loggers at INFO: they log every media packet at DEBUG, so enabling 'aidot' DEBUG flooded the log (~99% of lines in one capture). Useful aiortc DEBUG (DTLS/ICE/SCTP) still flows. - Demote the benign 'ignoring ASCII-encoded IP' cloud-quirk message to debug. 0.11.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log-volume + event-loop-blocking fixes surfaced from a live HA log review. 0.11.7.
Fixed
cache (
_inject_sprop->_load_sprop->open()) as an eagerly-evaluatedargument to
run_in_executor, so the blockingopen()executed on the loop -which HA flags as "a blocking call ... causing stability issues". Moved the read
inside the executor at all three SDP-write sites (
sdes_open.py792/1774/2072).Changed
log every media packet at DEBUG; enabling DEBUG on the parent
aidotloggerturned that into thousands of lines/second (~99% of all lines in a live
capture).
rtcrtpreceiver/rtcrtpsenderare capped at INFO by default (explicituser level respected); DTLS/ICE/SCTP aiortc DEBUG still flows.
Verification
and that the aiortc packet flood is gone with
aidotDEBUG enabled.