Thm segregate#3
Open
shyaan wants to merge 57 commits into
Open
Conversation
kks32
requested changes
Apr 10, 2020
| # so we provide an option similar to BUILD_TESTING, but just for THM. | ||
| option(THM_BUILD_TESTING "enable testing for thm" ON) | ||
|
|
||
| # Add -O0 to remove optimizations when using gcc |
Contributor
There was a problem hiding this comment.
You don't need this, please pass -DCMAKE_BUILD_TYPE=Debug when compiling
Contributor
Author
There was a problem hiding this comment.
make "DCMAKE_BUILD_TYPE=Debug" ?
Contributor
There was a problem hiding this comment.
cmake -DCMAKE_BUILD_TYPE=Debug
kks32
requested changes
Apr 17, 2020
kks32
left a comment
kks32
left a comment
Contributor
There was a problem hiding this comment.
Please don't add binary files and perf files to the code repository
| # so we provide an option similar to BUILD_TESTING, but just for THM. | ||
| option(THM_BUILD_TESTING "enable testing for thm" ON) | ||
|
|
||
| # Add -O0 to remove optimizations when using gcc |
Contributor
There was a problem hiding this comment.
cmake -DCMAKE_BUILD_TYPE=Debug
|
|
||
| #include "globalvariables.h" | ||
|
|
||
| using namespace dealii; |
Contributor
There was a problem hiding this comment.
It's recommended to avoid defining using namespace please use dealii::fn to be more precise.
|
|
||
| using namespace dealii; | ||
|
|
||
| namespace EquationData { |
Contributor
There was a problem hiding this comment.
Please use lower case for namespace names
Contributor
Author
|
Hi ,Krishna,
Because I am using vscode and using a fast pull and push operation to push and pull codes, I can not control what I can push and what I can’t push. Do you have any suggestion? Thanks a lot.
Best,
Xiang
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: Krishna Kumar<mailto:notifications@github.com>
Sent: 2020年4月16日 18:34
To: cb-geo/thm<mailto:thm@noreply.github.com>
Cc: shyaan<mailto:shyaansun@outlook.com>; Author<mailto:author@noreply.github.com>
Subject: Re: [cb-geo/thm] Thm segregate (#3)
@kks32 requested changes on this pull request.
Please don't add binary files and perf files to the code repository
In CMakeLists.txt<#3 (comment)>:
@@ -35,6 +35,12 @@ endif()
# so we provide an option similar to BUILD_TESTING, but just for THM.
option(THM_BUILD_TESTING "enable testing for thm" ON)
+# Add -O0 to remove optimizations when using gcc
cmake -DCMAKE_BUILD_TYPE=Debug
In include/boundaryvalues.h<#3 (comment)>:
@@ -0,0 +1,137 @@
+#pragma once
+
+#include <fstream>
+#include <iostream>
+
+// #include <deal.II/numerics/vector_tools.h>
+#include <deal.II/base/function.h>
+#include <deal.II/lac/vector.h>
+
+#include "globalvariables.h"
+
+using namespace dealii;
It's recommended to avoid defining using namespace please use dealii::fn to be more precise.
In include/boundaryvalues.h<#3 (comment)>:
@@ -0,0 +1,137 @@
+#pragma once
+
+#include <fstream>
+#include <iostream>
+
+// #include <deal.II/numerics/vector_tools.h>
+#include <deal.II/base/function.h>
+#include <deal.II/lac/vector.h>
+
+#include "globalvariables.h"
+
+using namespace dealii;
+
+namespace EquationData {
Please use lower case for namespace names
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AH3RE3MYFQP7WQ2UG5C2FWTRM6WZDANCNFSM4LGQ4EXA>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please add this branch.