fix: use MDN specified OKLCH syntax, remove multiplier and Math.round#349
Open
IdrisGit wants to merge 1 commit into
Open
fix: use MDN specified OKLCH syntax, remove multiplier and Math.round#349IdrisGit wants to merge 1 commit into
IdrisGit wants to merge 1 commit into
Conversation
… on values. - Correct OKLCH syntax is `oklch(x y z)` - OKLCH is very senstive to values specially the Hue value, rounding it can cause color mistmatch - C (chroma) is not [0,1], it more like [0,0.4] practically and percentages don't just convert 1:1,so browsers will convert x% to (x/100) * 0.4 instead of just (x/100)
scarcekoi
approved these changes
Jun 15, 2026
scarcekoi
left a comment
scarcekoi
left a comment
Member
There was a problem hiding this comment.
The fixed decimal place implementation is correct (instead of rounding), and it now uses the correct format.
Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the official
catppuccin/palettegenerates the correct OKLCH values, thetoOklchhelper on the website is generating wrong values.oklch(x y z)and notoklch(x,y,z).Official MDN docs https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/color_value/oklch