docs: document fill()'s caller-supplied fillDeadline parameter - #131
Open
dev-aly3n wants to merge 1 commit into
Open
docs: document fill()'s caller-supplied fillDeadline parameter#131dev-aly3n wants to merge 1 commit into
fill()'s caller-supplied fillDeadline parameter#131dev-aly3n wants to merge 1 commit into
Conversation
fill() and fillOrderOutputs() document orderId, output and fillerData but not fillDeadline. The parameter is caller-supplied and checked only against block.timestamp; it is not validated against the order, which the output settler never sees. emitNotFilled already documents this expectation for its own fillDeadline argument; this brings the two fill entry points in line. Documentation only - no behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fill()andfillOrderOutputs()documentorderId,outputandfillerDatabut notfillDeadline.The parameter is caller-supplied and checked only against
block.timestamp; it is not validated against the order, which the output settler never sees. That is clearly intentional, but the omission is costly for integrators: passing a padded value lets a late fill succeed, andInputSettlerBase._validateFillsthen rejects the claim permanently withFilledTooLate(the fill timestamp is bound into the proof payload hash, so it cannot be misreported). Passing the order's true deadline makes the same late fill revert cheaply instead.Documentation only. No behaviour change. Found while integrating a solver against the contracts deployed on 2026-08-06.
Related Issues
fill()'s caller-suppliedfillDeadlineparameter openintentsframework/oif-contracts#193Third-Party Integration Checklist
N/A. This PR does not integrate with any external protocol: no new dependencies, no interfaces copied.
Additional Notes
Touches only the natspec blocks of
fill()andfillOrderOutputs()insrc/output/OutputSettlerBase.sol. No logic, no ABI and no bytecode change, so gas snapshots are unaffected.