fix: properly handle dynamic System.import on the client - #5
Open
pkozlowski-opensource wants to merge 1 commit into
Open
fix: properly handle dynamic System.import on the client#5pkozlowski-opensource wants to merge 1 commit into
pkozlowski-opensource wants to merge 1 commit into
Conversation
Author
|
@caridy I was trying to add proper tests for this, but from my exploration of the tests in this project, my understanding is that I could only add manual tests for the client-side part, right? If so I would need a bit of input from you as current manual tests seem to be "broken" - we are referencing a non-existing |
Owner
There was a problem hiding this comment.
I see the problem here, but removing the around promise is not the solution since that promise protects issues with normalizeName and get.
The problem here is really that resolve is never called when load is invoked. The solution should be to propagate resolve and reject a then() when calling load().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4