Add filter for observability environment output#4736
Conversation
Observability diff (vs staging)No dashboard / folder changes detected against the staging Grafana. (Run: https://github.com/cardstack/boxel/actions/runs/25583379584) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d47e41cf7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| # Catch typos early; otherwise the rendered file would have an empty `contexts:` | ||
| # mapping and grafanactl would emit a confusing error. | ||
| if ! grep -qE "^ ${target_env}:[[:space:]]*\$" "$src"; then |
There was a problem hiding this comment.
The new typo guard uses grep -E with unescaped user input, so any regex metacharacters in target_env can produce false positives. For example, ./scripts/render-config.sh 'prod.*' currently passes this check, emits an empty contexts: block, and only fails later with a less actionable context/config error, which defeats the stated goal of catching bad env names early. Treat target_env as a literal string (or avoid regex matching) so invalid names are always rejected at this step.
Useful? React with 👍 / 👎.
1 participant
When I’ve been trying to review observability PRs I’ve been repeatedly confused by these errors:
Today I realised that
--env localis being ignored. This is Claude’s suggestion about how to fix that, I can confirm it works for me locally, but I can’t vouch for its sensibility: