CS-11009: remove deprecated PRERENDER_PAGE_POOL_SIZE env var#4726
CS-11009: remove deprecated PRERENDER_PAGE_POOL_SIZE env var#4726
Conversation
The dynamic-pool config (MIN/MAX) is live in staging+prod, and the legacy PRERENDER_PAGE_POOL_SIZE env var has no runtime effect when MIN/MAX are set. Drop the consumer side here so the env var is fully dead once the matching infra PR removes the SSM wiring. - prerender-app.ts: drop the env var read; use a hardcoded default 5 for the maxPages fallback (only hit by tests, since deployed envs set MIN/MAX and local dev sets MIN=MAX=4) - mise-tasks/lib/env-vars.sh: set PRERENDER_PAGE_POOL_MIN/_MAX=4 instead of PRERENDER_PAGE_POOL_SIZE; AFFINITY_TAB_MAX falls back to its in-code default (5, clamped to MAX=4) - README, aws-operations rollback section, and indexing-diagnostics skill: switch references to MIN/MAX - page-pool.ts: comment cleanup Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4414cf4ae3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Removes the deprecated PRERENDER_PAGE_POOL_SIZE environment variable from the prerender server’s configuration surface, updating local dev defaults and operational/docs to rely on the dynamic pool envelope (PRERENDER_PAGE_POOL_MIN / PRERENDER_PAGE_POOL_MAX) instead.
Changes:
- Dropped
PRERENDER_PAGE_POOL_SIZEconsumption in the prerender server app wiring and updated related comments. - Updated local dev env defaults to set
PRERENDER_PAGE_POOL_MIN/MAX(instead of the legacy size var). - Refreshed documentation and operator guidance to describe the dynamic pool envelope and rollback procedure.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates dev defaults and prerender env var documentation to reference PRERENDER_PAGE_POOL_MIN/MAX instead of PRERENDER_PAGE_POOL_SIZE. |
| packages/realm-server/prerender/prerender-app.ts | Removes legacy env var read for pool sizing (now options.maxPages ?? 5). |
| packages/realm-server/prerender/page-pool.ts | Comment cleanup to remove references to the deprecated env var and clarify fixed-size behavior. |
| mise-tasks/lib/env-vars.sh | Switches dev defaults from PRERENDER_PAGE_POOL_SIZE to PRERENDER_PAGE_POOL_MIN/MAX. |
| docs/aws-operations.md | Updates operator procedure/rollback guidance to focus on restoring previous envelope values. |
| .claude/skills/indexing-diagnostics/SKILL.md | Updates tuning table to describe PRERENDER_PAGE_POOL_MIN/MAX instead of the deprecated size var. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Host Test Results 1 files ±0 1 suites ±0 1h 43m 43s ⏱️ - 4m 26s Results for commit be7eb64. ± Comparison against earlier commit 4f8b2be. Realm Server Test Results 1 files ±0 1 suites ±0 13m 59s ⏱️ +30s Results for commit be7eb64. ± Comparison against earlier commit 4f8b2be. |
Summary
Follow-up to CS-10976. The dynamic-pool config (
PRERENDER_PAGE_POOL_MIN/_MAX) is live in staging+prod, so the legacyPRERENDER_PAGE_POOL_SIZEenv var has no runtime effect — when bothMINandMAXare set,page-pool.tsignoresoptions.maxPages(which is what the env var feeds). This removes the consumer side; the matching infra PR (cardstack/infra#687) drops the SSM wiring.prerender-app.ts:79— drop the env var read; theoptions.maxPagesfallback now defaults to5(only hit by tests, since deployed envs set MIN/MAX and local dev sets MIN=MAX=4)mise-tasks/lib/env-vars.sh— setPRERENDER_PAGE_POOL_MINand_MAX(=4) instead ofPAGE_POOL_SIZE.PRERENDER_AFFINITY_TAB_MAXfalls back to its in-code default (5), which clamps to MAX=4 — same effective value as before.README.md,docs/aws-operations.md(rollback section now points operators at restoring previous MIN/MAX values, per the ticket's guidance), and theindexing-diagnosticsskill's tuning table.page-pool.ts(the legacyelsebranch in the constructor stays — it's still reached by tests that don't set MIN/MAX env vars and passoptions.maxPagesdirectly).Operational order
PRERENDER_PAGE_POOL_SIZEfrom the ECS task wiring).aws --profile <env> ssm delete-parameter --name /<env>/boxel/PRERENDER_PAGE_POOL_SIZEfor staging and prod.boxel-prerender-server-<env>so running tasks no longer have the env var present.Test plan
pnpm lintpasses inpackages/realm-servermise run dev) boots prerender server withPRERENDER_PAGE_POOL_MIN=4/_MAX=4and works end-to-end against base realm cardsPRERENDER_PAGE_POOL_SIZEoutsidenode_modules🤖 Generated with Claude Code