Remove field-spec instances from packages/base by richardhjtan · Pull Request #4724 · cardstack/boxel

richardhjtan · 2026-05-08T06:23:15Z

The field-spec JSON files under packages/base/fields/ are moving to boxel-catalog.

Three host tests had hard-coded selectors pointing at the old base field-spec URLs. They now use inline fixtures in their test realms, making them self-contained.

There is a test to verify that the base specs exist in boxel-catalog: cardstack/boxel-catalog#557

github-actions · 2026-05-08T06:33:02Z

Preview deployments

Host staging preview

Host production preview

Host Test Results

1 files 1 suites 2h 3m 30s ⏱️
2 643 tests 2 628 ✅ 15 💤 0 ❌
2 662 runs 2 647 ✅ 15 💤 0 ❌

Results for commit 1a42cd3.

Realm Server Test Results

1 files ± 0 1 suites ±0 16m 48s ⏱️ + 11m 43s
1 297 tests +1 035 1 297 ✅ +1 035 0 💤 ±0 0 ❌ ±0
1 376 runs +1 105 1 376 ✅ +1 105 0 💤 ±0 0 ❌ ±0

Results for commit 1a42cd3. ± Comparison against earlier commit 4eb2ed9.

Copilot

Pull request overview

This PR removes the field-spec JSON instances from packages/base/fields/ (they’re moving to boxel-catalog) and updates host UI/tests to stop relying on the old https://cardstack.com/base/fields/* URLs by using inline fixtures and a configurable default field spec ID.

Changes:

Removed field-spec instance JSON files from packages/base/fields/.
Updated host runtime config to expose defaultFieldSpecId, and updated the “Create File” modal to use it for Field Definition defaults.
Updated integration/acceptance tests to use inline field-spec fixtures in their test realms and updated selectors to use testRealmURL.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/host/tests/integration/components/operator-mode/setup.gts	Adds an inline `fields/biginteger-field.json` fixture to the integration test realm.
packages/host/tests/integration/components/operator-mode-links-test.gts	Updates card-catalog selectors to use the test realm URL for the field spec.
packages/host/tests/acceptance/code-submode/schema-editor-test.ts	Adds inline field-spec fixtures (BigInteger/Date) and updates selectors to use the test realm URL.
packages/host/tests/acceptance/code-submode/create-file-test.gts	Adds inline fixtures for `fields/biginteger-field.json` and `fields/field.json`; updates selectors to use the test realm URL.
packages/host/config/environment.js	Introduces `ENV.defaultFieldSpecId` (test hardcode; computed from catalog realm when available).
packages/host/app/config/environment.ts	Extends the typed config shape with `defaultFieldSpecId?: string`.
packages/host/app/components/operator-mode/create-file-modal.gts	Uses `config.defaultFieldSpecId` as the default spec for Field Definition creation.
packages/base/fields/website-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/url-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/text-area-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/string-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/realm-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/phone-number.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/percentage-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/number-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/markdown-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/ethereum-address-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/email-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/datetime-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/date-range-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/date-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/country-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/command-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/color-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/code-ref-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/boolean-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/biginteger-field.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/base64-image.json	Removed base field spec instance JSON (moved to catalog).
packages/base/fields/address-field.json	Removed base field spec instance JSON (moved to catalog).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.

The field-spec JSON files under packages/base/fields/ are moving to boxel-catalog Three host tests had hard-coded selectors pointing at the old base field-spec URLs. They now use inline fixtures in their test realms, making them self-contained.

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a42cd3eee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-08T12:52:44Z

      withTrailingSlash(ENV.resolvedCatalogRealmURL),
    ).href;
+    ENV.defaultFieldSpecId = new URL(
+      'Spec/fields/field',


Point default field spec ID at the moved fields path

The new production default uses Spec/fields/field, but the moved field-spec fixtures and updated tests in this change consistently use fields/field (for example http://test-realm/test/fields/field). When CreateFileModal opens a field-definition flow, it waits for defaultSpecResource.isLoaded; if this URL 404s in catalog, the modal stays in loading state and users cannot create field definitions without manual recovery. This should use the actual moved field-spec path under fields/.

Useful? React with 👍 / 👎.

habdelra · 2026-05-08T12:59:47Z

Probably you want to link this to the PR that adds them in catalog. the merge for this which does the staging deploy and the production deploy for this absolutely need to be coordinated with their addition to the catalog realm in each environment, or it will be a very chaotic transition. cardstack/boxel-catalog#557

richardhjtan force-pushed the CS-11032-remove-base-specs branch from 1a9f85c to 3715b19 Compare May 8, 2026 09:28

richardhjtan requested a review from Copilot May 8, 2026 09:32

Copilot started reviewing on behalf of richardhjtan May 8, 2026 09:32 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread packages/host/app/components/operator-mode/create-file-modal.gts Outdated

Comment thread packages/host/config/environment.js

richardhjtan force-pushed the CS-11032-remove-base-specs branch from 3715b19 to 21283a5 Compare May 8, 2026 11:08

richardhjtan requested a review from Copilot May 8, 2026 11:10

Copilot started reviewing on behalf of richardhjtan May 8, 2026 11:10 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread packages/host/app/components/operator-mode/create-file-modal.gts

Comment thread packages/host/config/environment.js

richardhjtan force-pushed the CS-11032-remove-base-specs branch 3 times, most recently from 31e26c1 to 4eb2ed9 Compare May 8, 2026 12:13

richardhjtan requested a review from Copilot May 8, 2026 12:14

Copilot started reviewing on behalf of richardhjtan May 8, 2026 12:14 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread packages/host/config/environment.js

richardhjtan force-pushed the CS-11032-remove-base-specs branch from 4eb2ed9 to 1a42cd3 Compare May 8, 2026 12:26

richardhjtan requested a review from Copilot May 8, 2026 12:26

Copilot started reviewing on behalf of richardhjtan May 8, 2026 12:27 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread packages/host/config/environment.js

richardhjtan marked this pull request as ready for review May 8, 2026 12:48

richardhjtan requested review from a team May 8, 2026 12:48

chatgpt-codex-connector Bot reviewed May 8, 2026

View reviewed changes

habdelra approved these changes May 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove field-spec instances from packages/base#4724

Remove field-spec instances from packages/base#4724
richardhjtan wants to merge 1 commit intomainfrom
CS-11032-remove-base-specs

richardhjtan commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 8, 2026

Uh oh!

habdelra commented May 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

richardhjtan commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview deployments

Host Test Results

Realm Server Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

habdelra commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 8, 2026 •

edited

Loading

habdelra commented May 8, 2026 •

edited

Loading