Skip to content

runtime-common: prettier --fix follow-up to #4628#4713

Merged
lukemelia merged 1 commit intomainfrom
fix/runtime-common-prettier-after-4628
May 7, 2026
Merged

runtime-common: prettier --fix follow-up to #4628#4713
lukemelia merged 1 commit intomainfrom
fix/runtime-common-prettier-after-4628

Conversation

@lukemelia
Copy link
Copy Markdown
Contributor

Summary

#4628 shortened two expressions in realm-index-card.ts and url.ts so they now fit on one line but left them wrapped, which prettier flags. The lint job has been failing on every PR opened against main since #4628 merged — confirmed at least three branches affected (#4711, cs-11082-bench-realm-gate, cs-11083-grafana-full-reindex-only-reindexes-lazy-mounted-realms-on).

Pure formatting; no behavior change.

-    return (
-      realmPaths.inRealm(cardURL) &&
-      realmPaths.local(cardURL) === 'index'
-    );
+    return realmPaths.inRealm(cardURL) && realmPaths.local(cardURL) === 'index';

Test plan

  • pnpm run lint:js in packages/runtime-common passes after the fix.

🤖 Generated with Claude Code

#4628 (Update RealmPaths#inRealm to handle both formats) shortened the
inline expressions in realm-index-card.ts and url.ts so they now fit
on one line, but left the previous wrapped layout in place. Prettier's
auto-format catches it; the lint job started failing on every PR
opened against main since #4628 merged.

Pure formatting; no behavior change. Verified via `pnpm run lint:js`
in `packages/runtime-common` after the fix.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@lukemelia lukemelia requested review from a team and backspace May 7, 2026 16:56
@backspace
Copy link
Copy Markdown
Contributor

thanks for catching this, I didn’t notice the lint job failing after my last commit

@lukemelia lukemelia merged commit 6ad4bbe into main May 7, 2026
17 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Host Test Results

    1 files      1 suites   2h 1m 21s ⏱️
2 634 tests 2 619 ✅ 15 💤 0 ❌
2 653 runs  2 638 ✅ 15 💤 0 ❌

Results for commit 48e6001.

Realm Server Test Results

    1 files      1 suites   17m 38s ⏱️
1 262 tests 1 262 ✅ 0 💤 0 ❌
1 340 runs  1 340 ✅ 0 💤 0 ❌

Results for commit 48e6001.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants