Conversation
Host Test Results 1 files ±0 1 suites ±0 2h 3m 34s ⏱️ +45s Results for commit b5a7340. ± Comparison against earlier commit 32d4f16. Realm Server Test Results 1 files ± 0 1 suites ±0 16m 31s ⏱️ - 1m 27s Results for commit b5a7340. ± Comparison against earlier commit 32d4f16. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecfc4214a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,3 +0,0 @@ | |||
| { | |||
| "showAsCatalog": false | |||
There was a problem hiding this comment.
Removing this file deletes the only source of showAsCatalog: false for the bootstrap base realm, so runRealmMetadataBackfill no longer seeds realm_metadata.show_as_catalog=false for https://cardstack.com/base/ on fresh databases. In that state, realm info returns showAsCatalog=null, and handle-fetch-catalog-realms only filters realms when the value is explicitly false, which makes the base realm appear in /_catalog-realms unexpectedly.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This has revealed an error, NULL in show_as_catalog shouldn’t be interpreted as a catalog realm! Fixed in 32d4f16
NULL shouldn’t be interpreted as being a catalog realm!
1 participant
With #4508 being merged, this file is no longer needed and is producing diff noise whenever we run the stack locally.
show_as_catalogwill be false by default.