Skip to content

Add ESLint & Prettier configuration #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cardseditor merged 7 commits into from
Jun 5, 2025
Merged

Add ESLint & Prettier configuration #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1bc7327
chore: add eslint and prettier with CI
cardseditor Jun 5, 2025
8d86a1e
fix: push to PR branch in CI
cardseditor Jun 5, 2025
06d121a
chore: update lint config and ci
cardseditor Jun 5, 2025
9f09913
fix: push lint results to correct branch
cardseditor Jun 5, 2025
6f360a2
chore(ci): ignore workflow files from format commit
cardseditor Jun 5, 2025
33efaa3
chore: apply lint and format
invalid-email-address Jun 5, 2025
a02ec03
ci: avoid duplicate builds
cardseditor Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
node_modules
.next
out
build
.github
5 changes: 5 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module.exports = {
root: true,
ignorePatterns: ['node_modules/', '.next/', 'out/', 'build/'],
extends: ['next/core-web-vitals', 'plugin:prettier/recommended']
}
22 changes: 22 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ name: Build

on:
push:
branches:
- main
pull_request:
branches:
- main

env:
BUN_VERSION: '1.2.15'
Expand All @@ -12,11 +16,29 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
ref: ${{ github.head_ref || github.ref }}
- name: Setup Bun
uses: oven-sh/setup-bun@v1
with:
bun-version: ${{ env.BUN_VERSION }}
- name: Install dependencies
run: bun install
- name: Lint and format
run: |
bunx eslint . --fix
bunx prettier -w .
- name: Commit changes
run: |
branch="${{ github.head_ref || github.ref_name }}"
if [ -n "$(git status --porcelain)" ]; then
git config user.name "github-actions"
git config user.email "github-actions@github.com"
git add .
git reset .github/
git commit -m "chore: apply lint and format"
git push origin HEAD:$branch
fi
- name: Build
run: bun run build
5 changes: 5 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
node_modules
.next
out
build
.github
7 changes: 7 additions & 0 deletions .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"semi": false,
"singleQuote": true,
"printWidth": 80,
"tabWidth": 2,
"trailingComma": "none"
}
6 changes: 3 additions & 3 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"editor.tabSize": 2
}
{
"editor.tabSize": 2
}
9 changes: 6 additions & 3 deletions app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,18 @@ import { ReactNode } from 'react'
export const metadata = {
title: 'CardsEditor',
icons: {
icon: '/images/profile.png',
},
icon: '/images/profile.png'
}
}

export default function RootLayout({ children }: { children: ReactNode }) {
return (
<html lang="ja">
<head>
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:wght@300" />
<link
rel="stylesheet"
href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:wght@300"
/>
</head>
<body>{children}</body>
</html>
Expand Down
Loading
Loading