draft for a stecker bus#30
Conversation
|
Thanks for this, eager to try it out! Some first comments regarding the questions
They are not exclusive as both types use a separate dictionary on the server.
It is possible to put multiple streams into one WebRTC connection - currently we try to keep things simple. How to handle multi-channel signals is somehow complex as we also wouldn't like to spill the web frontend with multi-channel rooms. |
|
Ah good, then I'll split them up again, Naming, naming:
I think the room metaphor is the best, but what do you think? |
|
The examples are in comments (which now don't get "autoformatted" anymore!!. I see that I want the IDE to do region selection also in comments …) |
|
Ah sorry, this hasn't been merged yet - let's merge and test it. @telephon can you apply the formatting (simply run |
capital-G
left a comment
There was a problem hiding this comment.
Ah, still had an un-saved review.
| var <bus, <synth; | ||
| var <>graceTime = 3, <fresh = true; | ||
|
|
||
| classvar <>all; |
There was a problem hiding this comment.
Should there be a setter for this?
Also this combines Data and Audio rooms, maybe use?
classvar <audioBusses;
classvar <controlBusses;
There was a problem hiding this comment.
Actually, I thought that it may be better to separate the two again.
I just can't think of good names!
There was a problem hiding this comment.
Maybe: Stecker and DataStecker?
| ^res | ||
| } | ||
|
|
||
| *ar { |roomName, numChannels| |
There was a problem hiding this comment.
Should numChannels default to 1?
There was a problem hiding this comment.
for audio, normally you would expect 2.
But currently we only support 1, we need to be a bit careful. It woun't be complicated to implement multichannel via (internally) modified room names (like \foo_2)
| } | ||
|
|
||
| *new { |roomName, input| | ||
| var res = all[roomName]; |
There was a problem hiding this comment.
I know res is proxy-speak, but I'd found steckerBus a bit more clear in this case.
|
OK, did a refactoring … |
|
@capital-G is there anything needed? |
updating branch from main
This is a first draft. It works fine, for one channel.
I wonder if:
-- I can't think of good names.
-- the room names are global between KR and AR, right? So if there exists an ar-room, I can't make a kr-room of the same name.