Route skill/workflow improvement notes to Skill Evolution Advisor

[caozx1110]

References / 关联

• Refs [Bug] 将 skill 优化项从讨论归档正确路由至 Skill Evolution Advisor #32
• Parent Epic：N/A（独立 bugfix）
• Delivery wave：single atomic bugfix
• Baseline SHA：2eed117a76c326d24dd3402f104b2ee5a71554d6
• Candidate head SHA：7f95f29f2ca97c263b2993c2c6d03d542e7537f8
• Delivery branch：codex/issue-32-route-skill-optimization

Outcome

明确的 skill/workflow 优化记录请求会交给 skill-evolution-advisor，不再被泛化的“讨论 / discussion”单独吞掉；如果同一请求还独立要求归档研究路线讨论，snapshot 保留两个 owner 并要求 research-orchestrator 形成有依赖顺序的 route decision。

Scope / Non-goals

Scope

• 增加受限的中英文 meta-workflow phrase matcher，并保留 factual route snapshot。
• 在明确 meta-workflow 命中时压制泛化 discussion hint；明确 research-route discussion 仍归档。
• 同步 discussion/evolution/orchestrator 的 trigger boundary、metadata SSOT 与生成的 OpenAI metadata。
• 固定 direct、suppression、composed、ambiguous、negative 中英文回归。

Non-goals

• 不把模型、方法、实验等泛化“优化”归为 skill 演化。
• 不改变 diagnostics/learnings schema、confirmation、journal、recovery 或公开 kb 动词。
• 不自动修改 skill、roadmap 或用户研究结论。

Implementation / 实现摘要

• research-orchestrator 仅在 skill/技能/workflow/工作流 与改进语义成对出现，或出现明确“流程问题/摩擦”时加入 evolution owner。
• 发现 evolution 命中后，普通 讨论/discussion 会被标记为 suppressed；研究路线讨论 及英文对应表达仍保留 discussion owner。
• 新增“先…再…”组合标记；双意图 snapshot 由 orchestrator 接管，测试验证 evolution → discussion 的依赖顺序。
• 三个 owner 的 metadata 与 SKILL.md 使用互补正/负边界；skill defect/candidate 仍是 record-only。

并行 track 集成

N/A；单一 branch、单一 integrator、单一 commit。

• 全部需要的改动已进入本 candidate，人类无需拼装分支
• [Wave 3][Enhancement] 最小化 always-on runtime 规则并落实 skill 渐进式披露 #22 仍为 draft-blocked，本 Issue 按串行顺序拥有重叠 metadata 路径
• 无必要状态仅存在于 worktree/stash/untracked/未 push commit/本机日志

Validation / 验收证据

Acceptance item	Result	Command/environment	GitHub evidence
Direct/composed/ambiguous/negative routing	PASS	focused pytest: 35 passed	candidate SHA + Actions
Metadata and owner boundary consistency	PASS	generated metadata check + 15-skill validator	candidate SHA + Actions
Full regression	PASS	pytest tests -q: 2534 passed, 18 skipped, 5 warnings	candidate-head run 31128458272
Fresh-process isolated acceptance	PASS	five sanitized requests in an empty temporary workspace; zero files written	candidate checkpoint on #32

测试与 CI

• Candidate-head Actions run / SHA：run 31128458272, 3/3 success / 7f95f29f2ca97c263b2993c2c6d03d542e7537f8

• PR merge-candidate Actions run / base SHA：run 31129601298, 3/3 success / 2eed117a76c326d24dd3402f104b2ee5a71554d6

• Full/target test summary：full 2534 passed, 18 skipped, 5 warnings; focused 35 passed; expanded owner/docs/pure-reader 41 passed

• Static gates：metadata byte-current、15-skill validator、rule-token、compileall、bash -n install.sh、changed CLI help、git diff --check 均通过

• Cold acceptance：PASS；空临时 workspace 零写入

• 相关定向测试通过

• 完整本地门禁通过

• Current-base tested-merge Actions 通过

• 承重 bug 已在 baseline 复现并由回归固定

Risks / 安全、治理与数据边界

• 真实用户 kb/ 未读取或修改；验收使用隔离临时目录
• 确认、逐字 evidence、恢复和用户输出合同未削弱
• Issue/PR 未泄漏真实用户数据、本机路径、token、secret 或未公开研究
• 无未登记 scope creep；未改 schema 或数据布局
• Agent 未直推 default、self-approve、self-merge、tag、release 或 publish

Documentation, migration, rollback, and Known limits / 文档、迁移与回滚

• docs/DESIGN.md / ADR / schema / 用户文档 / CHANGELOG：无需修改；这是既有 owner 合同内的局部路由修复，触发边界已在三个 SKILL.md 与 metadata 同步。
• 迁移：无。
• 回滚/降级：revert 本 PR；没有 canonical record 或用户数据迁移需要恢复。
• 已知限制 / 后续：关键词仅提供 factual hints；无上下文或其他复合意图仍由 runtime Agent 规划。[Wave 3][Enhancement] 最小化 always-on runtime 规则并落实 skill 渐进式披露 #22 后续重构 metadata 时必须保留本 PR 的边界。

人类 review gate

• PR 是完整集成候选，不是半成品内部分支
• Current-base required CI checks 全部通过
• Candidate SHA、测试证据、风险和回滚可从 GitHub 访问
• 维护者完成手动检查并决定 merge 或提出修改
• Agent 停在等待人类审查，不执行 merge

合并后收尾（merge 后填写）

• Actual merge SHA：pending
• Default-branch smoke / Actions：pending
• Atomic Issue final comment：pending
• Epic wave updated：N/A

[Copilot]

Pull request overview

This PR adjusts the research routing contract so explicit “skill/workflow improvement notes” are routed to skill-evolution-advisor (and generic discussion hints are suppressed), while explicit research-route discussion archiving remains owned by discussion-archivist; composed requests are intended to preserve both owners and require an ordered research-orchestrator route decision.

Changes:

• Extend research-orchestrator route hinting to detect bounded skill/workflow improvement phrases and suppress generic 讨论/discussion hits when that meta-workflow intent is present.
• Update discoverable metadata/prompts and SKILL docs for skill-evolution-advisor, discussion-archivist, and research-orchestrator to align with the new routing boundary.
• Add regression tests covering direct, suppressed, negative, and composed routing cases.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/test_skill_metadata.py	Adds assertions to ensure meta-skill prompts expose complementary routing boundaries.
tests/test_orchestrator_route_hints.py	Adds routing regression cases for skill/workflow improvement, suppression, negative optimization, explicit route-discussion, and composed intents.
skills/skill-evolution-advisor/SKILL.md	Updates description and adds an explicit trigger boundary section clarifying scope and non-goals.
skills/skill-evolution-advisor/agents/openai.yaml	Updates short description and default prompt to match the new boundary.
skills/research-orchestrator/SKILL.md	Clarifies that explicit skill/workflow improvement belongs to evolution advisor and composed cases require ordered decisions.
skills/research-orchestrator/scripts/orchestrate.py	Implements meta-workflow regex matching, explicit-discussion hint set, and suppression logic updates.
skills/research-orchestrator/agents/openai.yaml	Updates prompt to emphasize ordered route decisions for composed/ambiguous requests.
skills/metadata.yaml	Updates discoverable catalog prompts for the three relevant skills to reflect the new routing contract.
skills/discussion-archivist/SKILL.md	Updates description and adds a trigger boundary section explicitly excluding skill/workflow improvement notes.
skills/discussion-archivist/agents/openai.yaml	Updates short description and default prompt to align with the revised boundary.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.