Skip to content

test(core-acs-reader): add unit tests#1924

Open
mateuszpiatkowski-da wants to merge 10 commits into
mainfrom
mateuszpiatkowski-da/core-acs-reader-unit-tests
Open

test(core-acs-reader): add unit tests#1924
mateuszpiatkowski-da wants to merge 10 commits into
mainfrom
mateuszpiatkowski-da/core-acs-reader-unit-tests

Conversation

@mateuszpiatkowski-da

Copy link
Copy Markdown
Contributor

No description provided.

@mateuszpiatkowski-da mateuszpiatkowski-da self-assigned this Jun 1, 2026
@mateuszpiatkowski-da mateuszpiatkowski-da linked an issue Jun 1, 2026 that may be closed by this pull request
@mateuszpiatkowski-da mateuszpiatkowski-da marked this pull request as ready for review June 1, 2026 13:19
@mateuszpiatkowski-da mateuszpiatkowski-da requested a review from a team as a code owner June 1, 2026 13:19
Comment thread core/acs-reader/src/cache/__test__/cache.test.ts Outdated
Comment thread core/acs-reader/src/cache/__test__/cache.test.ts Outdated
Comment thread core/acs-reader/src/cache/__test__/cache.test.ts Outdated
Comment thread core/acs-reader/src/cache/__test__/collection.test.ts Outdated
@pawelstepien-da

Copy link
Copy Markdown
Contributor

Please also set coverage thresholds in vitest.config.ts to 70% branches and 80% other metrics.

@mateuszpiatkowski-da

mateuszpiatkowski-da commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Converting to draft since #1947 should be merged first as it will make substantial changes to code structure.

Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da mateuszpiatkowski-da force-pushed the mateuszpiatkowski-da/core-acs-reader-unit-tests branch from dcb2614 to 646b89d Compare June 11, 2026 09:58
@mateuszpiatkowski-da mateuszpiatkowski-da marked this pull request as ready for review June 11, 2026 09:58
@mateuszpiatkowski-da mateuszpiatkowski-da enabled auto-merge (squash) June 11, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

core-acs-reader unit tests

3 participants