Re-enable automaticSilentRenew on OidcAuthProvider#5937
Open
samsondav wants to merge 3 commits into
Open
Conversation
Signed-off-by: Sam Davies <sam@avrofi.com>
Signed-off-by: Sam Davies <sam@avrofi.com>
samsondav
force-pushed
the
sam-avro/issue-5682-silent-renew
branch
from
6baff34 to
a67932a
Compare
samsondav
force-pushed
the
sam-avro/issue-5682-silent-renew
branch
from
ab838a3 to
75d1365
Compare
Signed-off-by: Sam Davies <sam@avrofi.com>
samsondav
force-pushed
the
sam-avro/issue-5682-silent-renew
branch
from
75d1365 to
e3bb6a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5545 disabled
automaticSilentRenewwhen removing the globaloffline_accessscope. Keycloak still issues a session-bound refresh token without that scope, so silent renew can use the refresh_token grant and users are no longer forced back to the IdP on every short access-token expiry (default 5 minutes).Fixes #5682
Change
Re-enable
automaticSilentRenewonOidcAuthProvider.Testing
AuthProvider.test.tsxmocksreact-oidc-contextand assertsautomaticSilentRenew: trueis passed through. Also covers the hs256-unsafe short-circuit path.Note
This is the minimal fix Pawel asked for in lieu of #5683, which adds per-IdP
enable_offline_scopeconfiguration and operator docs. Auth0 deployments that requireoffline_accessto receive a refresh token may still need a follow-up if silent renew does not work there without that scope.