SvApp: For TBA use total app activity in SummarizingMiningRoundTrigger#5903
Draft
dfordivam wants to merge 6 commits into
Draft
SvApp: For TBA use total app activity in SummarizingMiningRoundTrigger#5903dfordivam wants to merge 6 commits into
dfordivam wants to merge 6 commits into
Conversation
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Contributor
Author
|
@meiersi-da This draft PR is ready for a first look. The CI won't pass on this yet, as it require TBA bootstrap support. |
meiersi-da
reviewed
Jun 12, 2026
Comment on lines
+166
to
+170
| val appRewardsInCc = | ||
| (BigDecimal(totalAppActivity) * BigDecimal(trafficPrice) / BigDecimal( | ||
| payload.amuletPrice | ||
| )).setScale(10, BigDecimal.RoundingMode.HALF_EVEN) | ||
| AppRewardCouponsSum(featured = appRewardsInCc, unfeatured = BigDecimal(0)) |
Contributor
There was a problem hiding this comment.
I'm a bit nervous about repeating this computation here. I'd prefer to keep it close to Scan where it is also tested.
Scan currently doesn't deliver this number, but it could: just sum these two values:
The change I'd actually suggest is to expose all the numbers from the app_reward_round_totals alongside the ones from the app_activity_round_totals. I suspect these could be helpful for debugging.
| val Seq(lowestOpen, middleOpen, highestOpen) = | ||
| previousOpenRounds.map(_.contract.payload.round.number) | ||
|
|
||
| actAndCheck(timeUntilSuccess = 90.seconds)("advancing time", advanceTime(advanceWith))( |
Contributor
There was a problem hiding this comment.
why do we need 90 seconds for this to complete?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5849
Note:
TrafficBasedRewardsTimeBasedIntegrationTestis broken currently, and require bootstrap with TBA enabled support #5624Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines