o/confdbstate: handle read/writes to builtin confdbs - #17455
Conversation
This allow reading and writing builtin confdb-schemas (i.e., those for which the account is "system"). It passes the read/write to the appropriate subsystem for commit instead of persisting databag changes. It also doesn't schedule any hooks except the observe-view hooks, since no snap can be a custodian for "system" confdbs. Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
miguelpires
added
the
confdb
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17455 +/- ##
==========================================
- Coverage 78.83% 78.75% -0.08%
==========================================
Files 1406 1408 +2
Lines 197646 197853 +207
Branches 2502 2502
==========================================
+ Hits 155808 155829 +21
- Misses 32468 32652 +184
- Partials 9370 9372 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Tue Aug 18 22:00:29 UTC 2026 Test Predictor AnalysisExecuting
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list of the below tests you wish to run (unskip plus test list must be valid yaml)
|
pedronis
left a comment
pedronis
left a comment
There was a problem hiding this comment.
thank you, comment and question
|
|
||
| chg := s.state.Change(chgID) | ||
| c.Assert(chg, NotNil) | ||
| c.Assert(chg.Status(), Equals, state.DoneStatus) |
There was a problem hiding this comment.
question, why we don't need to settle here?
There was a problem hiding this comment.
This falls into the path where there are no hooks to run so we just load the read data directly into the change and mark it as Done.
snapd/overlord/confdbstate/confdbstate.go
Line 935 in 4e63d1b
Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
| t.WaitAll(ts) | ||
| } | ||
| t.Set("scheduled-tasks", true) | ||
| t.SetStatus(state.DoStatus) |
There was a problem hiding this comment.
A comment explanation of why this is needed would be good. I would have thought just returning state.Retry would have been enough to get the behavior you wanted here.
github-actions
Bot
added
the
Auto rerun spread
3 participants
This allows reading and writing builtin confdb-schemas (i.e., those for which the account is "system"). It passes the read/write to the appropriate subsystem for commit instead of persisting databag changes. It also doesn't schedule any hooks except the observe-view hooks, since no snap can be a custodian for "system" confdbs.
https://warthogs.atlassian.net/browse/SNAPDENG-36956