Skip to content

Add ci-cla-check - #559

Merged
frederic-hoerni merged 3 commits into
masterfrom
add-ci-cla-check
Aug 18, 2026
Merged

Add ci-cla-check#559
frederic-hoerni merged 3 commits into
masterfrom
add-ci-cla-check

Conversation

@frederic-hoerni

Copy link
Copy Markdown
Collaborator

Verify whether or not the authors of a pull request have signed the Canonical Contributor Licence Agreement.

Verify whether or not the authors of a pull request have signed the Canonical
Contributor Licence Agreement.
@frederic-hoerni frederic-hoerni self-assigned this Aug 17, 2026
@frederic-hoerni
frederic-hoerni marked this pull request as draft August 17, 2026 13:18
Comment thread CONTRIBUTING.md Outdated
- Try not to mix potentially controversial and trivial changes together.
(Proposing trivial changes separately makes landing them easier and
makes reviewing controversial changes simpler)
- Do not [force push][git-force] a PR after it has received reviews. It is

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is [force push][git-force] for?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places with this syntax which I do not think it is valid markdown.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. But the same in snapd makes a valid link. I wonder why.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it! I'll fix that.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@frederic-hoerni
frederic-hoerni marked this pull request as ready for review August 18, 2026 12:01

@bboozzoo bboozzoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frederic-hoerni
frederic-hoerni merged commit 4622187 into master Aug 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants