fix(ci): avoid charm-checkout collision across sequential repo scans - #486
Merged
Conversation
scan-charm-repo cloned into a fixed ./charm-checkout path, which was fine when each matrix leg ran it once per runner. Now that scan-charms calls it once per repo from the same cwd, the second repo's clone collided with the first's leftover checkout and failed with: fatal: destination path 'charm-checkout' already exists and is not an empty directory. Clone into a fresh temp dir per call instead, and clean it up in a finally block so repeated/standalone runs don't leave state behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan-charm-repo clones into a fixed ./charm-checkout path. That was fine when each matrix leg ran it once per runner, but now that scan-charms loops it over every repo sequentially from the same cwd, the second repo's clone collides with the first's leftover checkout:
fatal: destination path 'charm-checkout' already exists and is not an empty directory.
Changes