Pin goroutine to OS thread when reading the primary key - #165
Open
gerald-yang-tw wants to merge 1 commit into
Open
Pin goroutine to OS thread when reading the primary key#165gerald-yang-tw wants to merge 1 commit into
gerald-yang-tw wants to merge 1 commit into
Conversation
The keyring links established by KEYCTL_LINK are per-thread, but Go may reschedule the goroutine onto a different OS thread between the link and the subsequent key read, making the read intermittently fail with permission denied: final reseal failed: cannot obtain auth key from kernel: cannot read key from kernel: cannot determine size of key payload: permission denied Wrap the link and read in runtime.LockOSThread()/UnlockOSThread() so both syscalls run on the same thread. Signed-off-by: Gerald Yang <gerald.yang@canonical.com>
Author
|
This issue can be reproduced on a azure CVM instance by running the following script: #!/bin/bash for i in {1..100}; do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyring links established by KEYCTL_LINK are per-thread, but Go may reschedule the goroutine onto a different OS thread between the link and the subsequent key read, making the read intermittently fail with permission denied:
final reseal failed: cannot obtain auth key from kernel: cannot read key from kernel: cannot determine size of key payload: permission denied
Wrap the link and read in runtime.LockOSThread()/UnlockOSThread() so both syscalls run on the same thread.