patch: fix has_file function to check on every unit instead of only checking the leader - #405
Open
patriciareinoso wants to merge 5 commits into
Open
patch: fix has_file function to check on every unit instead of only checking the leader#405patriciareinoso wants to merge 5 commits into
patriciareinoso wants to merge 5 commits into
Conversation
Gu1nness
reviewed
Aug 21, 2026
Contributor
There was a problem hiding this comment.
This change probably means we want to check that all calls to this function provide the leader as unit, but agreed !
Contributor
Author
There was a problem hiding this comment.
the has_file function is called twice (test_sharded_backups_tls.py and test_encryption_valid_scenario.py)
Both times the test iterates over all the units of the application and called the has_file functions.
So in fact we were checking multiple times that the leader unit has a file , no we check that each unit in the application has a file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷️ Type of changes
📝 Description
This PR make the function
has_fileto actually check the given unit instead of checking the leader unit.This function is used by:
which iterate over all the units of the application and call the
has_filefunction🧪 Manual testing steps
No need, this PR just modifies an check in the integration test
🔬 Automated testing steps
The integration tests using the
has_filefunction still pass✅ Checklist