-
Notifications
You must be signed in to change notification settings - Fork 80
test/e2e/run: Adjust tests to make script and TF plan work in offline environments #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ggouzi
wants to merge
1
commit into
canonical:main
Choose a base branch
from
ggouzi:update-e2e-tests-for-offline-envs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−28
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # LXD remote corresponding to the MicroCloud deployment to test. | ||
|
ggouzi marked this conversation as resolved.
|
||
| remote = "mc" | ||
|
|
||
| # LXD remote to fetch source images from | ||
| image_remote = "pcr-d" | ||
|
|
||
| # LXD project to cache source images into. Only needed when `project` has features.images=false | ||
| # (here, canonical-testing shares images with default). | ||
| image_project = "default" | ||
|
|
||
| # Whether to copy the source image's aliases to the cached image copy | ||
| # Set to true if image_remote's images carry aliases | ||
| copy_image_aliases = false | ||
|
|
||
| # LXD project/profile to use. By default, a project and profile named e2e-testing | ||
| # are created. Can be configured to reuse an existing project/profile by providing | ||
| # their names here; the project and profile will be created only if they do not already exist. | ||
| project = "canonical-testing" | ||
| profile = "canonical-testing-profile" | ||
|
|
||
| # Number of containers/VMs to create per cluster member. | ||
| # containers_per_host = 9 | ||
| # vms_per_host = 3 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used AI for this ugly command FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mh, if there is no easy way to achieve this, I would say let's have an additional TF var as you have proposed right from the start.
Doing this seems to be not the right way.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MusicDin do you know if there is a way to check for an existing project/profile and create if it doesn't yet exist (in terraform)?