Support juju 4 in integration tests - #596
Open
Thanhphan1147 wants to merge 12 commits into
Open
Conversation
juju ssh fails on Juju 4 with 'Permission denied (publickey)' due to changed SSH key provisioning timing. Replace all ssh calls that read files on units with juju.exec(..., unit=...).stdout, which routes through the Juju agent and requires no SSH keypair. Affected tests: test_haproxy_route, test_haproxy_route_tcp (x4), test_haproxy_ddos, and the apache2 log helper.
github-actions
Bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
labels
Thanhphan1147
changed the title
Dependency charms (postgresql 16/edge, postgresql-k8s 14/edge, hydra, kratos, traefik-k8s, identity-platform-login-ui-operator, self-signed-certificates) declare 'assumes: juju < 4.0.0' (or < 3.5.0), blocking deployment on Juju 4. Juju 4's deploy validator skips assumes checks when --force is passed. Add force=True to all external charm deploys in test fixtures so the assumes gate is bypassed without changing the charm revisions. Affected fixtures: postgresql_fixture, deploy_iam_bundle_fixture, certificate_provider_application_fixture (both top-level and haproxy-operator conftest).
github-actions
Bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
Thanhphan1147
added
the
no-release-note
github-actions
Bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
Bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
Bot
added
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
Bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
…ility Juju 4 injects additionalProperties: false into all action schemas at charm load time (domain/deployment/charm/actions.go). Any param not declared in actions.yaml is now rejected with a validation error. The rpc action on any-charm only declares method, args, and kwargs. The call at line 158 was passing protocols as a top-level param, which Juju 3 silently accepted but Juju 4 rejects. Move protocols into the kwargs JSON string so it is correctly dispatched to start_ssl_server as a Python keyword argument.
github-actions
Bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Replaces all
juju.ssh(unit, cmd)/cli("ssh", ...)calls that read files on units withjuju.exec(cmd, unit=...).stdout.Why
On Juju 4,
juju sshfails immediately after deploy with:This is due to changed SSH key provisioning/propagation timing in Juju 4.
juju execroutes through the Juju agent and requires no SSH keypair, making it reliable regardless of timing.Affected files
haproxy-operator/tests/integration/test_haproxy_route.py— readhaproxy.cfghaproxy-operator/tests/integration/test_haproxy_route_tcp.py— 4 reads ofhaproxy.cfgtests/integration/test_haproxy_ddos.py— waslxd_juju.cli("ssh", ...), nowlxd_juju.exec(...)haproxy-operator/tests/integration/helper.py— apache2 access-log grepPart of
Juju 4 integration test migration tracked in #577.