Skip to content

DNR/DNM : Update Makefile #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jsimpso wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

DNR/DNM : Update Makefile #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ errmsg = @printf '$(RED_COLOR)Error: $(1)$(NO_COLOR)\n' && exit 1

include Makefile.docs

.PHONY: help
.PHONY: halp

@yhaliaw yhaliaw Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .PHONY declaration was changed from help to halp, but the help: target immediately below is unchanged. This means help is no longer declared phony — if a file named help ever appears in the repo root, make help would be treated as up-to-date and silently skip running _list-targets. The halp phony entry is dead (no rule exists for it).

Given that the PR description explicitly says "DO NOT MERGE/REVIEW", this looks like a stray/WIP commit. Please revert to .PHONY: help (and drop the trailing space) before this is considered for merge.

Suggested change
.PHONY: halp
.PHONY: help

🤖 AI-assisted

help: _list-targets ## Prints all available targets

.PHONY: _list-targets
Expand Down
Loading