Skip to content

problem_report: submit JSON attachments as such - #631

Merged
bdrung merged 1 commit into
canonical:mainfrom
bdrung:json-file
Aug 18, 2026
Merged

problem_report: submit JSON attachments as such#631
bdrung merged 1 commit into
canonical:mainfrom
bdrung:json-file

Conversation

@bdrung

@bdrung bdrung commented Jul 2, 2026

Copy link
Copy Markdown
Member

There might be fields like pro-status.json (from ubuntu-advantage-tools source hook) or CoredumpPackageJson that contain JSON data.

Upload those attachments with the correct file extension and with MIME type application/json.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.48%. Comparing base (4f49118) to head (522aaca).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   84.45%   84.48%   +0.02%     
==========================================
  Files         106      106              
  Lines       20996    21034      +38     
  Branches     3187     3189       +2     
==========================================
+ Hits        17733    17770      +37     
+ Misses       2791     2790       -1     
- Partials      472      474       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdrung
bdrung requested a review from Hyask July 3, 2026 15:09

@Hyask Hyask left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There might be fields like `pro-status.json` (from
ubuntu-advantage-tools source hook) or `CoredumpPackageJson` that
contain JSON data.

Upload those attachments with the correct file extension and with MIME
type `application/json`.
@bdrung

bdrung commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

Rebased and addressed ruff complaints: combined name.endswith("Json") or name.endswith(".json") to name.endswith(("Json", ".json")).

@bdrung
bdrung merged commit 522aaca into canonical:main Aug 18, 2026
28 checks passed
@bdrung
bdrung deleted the json-file branch August 18, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants