Skip to content

update#1

Open
camysidron1 wants to merge 1 commit into
mainfrom
chore/update-subprotocol
Open

update#1
camysidron1 wants to merge 1 commit into
mainfrom
chore/update-subprotocol

update

75240a4
Select commit
Loading
Failed to load commit list.
Pi Security Bot / Nebari / Security Scan required action Oct 29, 2025 in 1m 47s

Security Review Required

Summary: PR violates OCPP specification by changing WebSocket subprotocol from correct 'ocpp1.6' to incorrect 'ocpp-1.6', which will break protocol negotiation and prevent secure OCPP communication.

Critical Security Issues

1. Protocol Compliance Violation in src/MicroOcpp.cpp

WebSocket subprotocol changed from OCPP-compliant 'ocpp1.6' to non-compliant 'ocpp-1.6'. According to OCPP specification (Table 1), OCPP version 1.6 must use subprotocol name 'ocpp1.6' without hyphen. This will cause WebSocket handshake failures with compliant OCPP backend servers.

2. Protocol Compliance Violation in src/MicroOcpp.cpp

WebSocket subprotocol changed from OCPP-compliant 'ocpp1.6' to non-compliant 'ocpp-1.6' in non-TLS connection. According to OCPP specification (Table 1), OCPP version 1.6 must use subprotocol name 'ocpp1.6' without hyphen. This will cause WebSocket handshake failures with compliant OCPP backend servers.