fix: restore subgroup indentation in TaskList views#1788
Open
renatomen wants to merge 2 commits intocallumalpass:mainfrom
Open
fix: restore subgroup indentation in TaskList views#1788renatomen wants to merge 2 commits intocallumalpass:mainfrom
renatomen wants to merge 2 commits intocallumalpass:mainfrom
Conversation
Subgroup header indentation CSS selectors had a typo (tn-tasknoteTaskList instead of tn-tasknotesTaskList) causing the rules to never match. Also added margin-left to task cards under subgroups so their chevrons align directly below the subgroup header chevron.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes subgroup headers not displaying with proper indentation in TaskList views when sub-grouping is configured.
Problem
When viewing tasks with both primary grouping and sub-grouping enabled, sub-headers were rendering at the same level as primary headers without visual indentation, making the hierarchy unclear.
Before: Sub-headers appeared flush left with primary headers
After: Sub-headers display with 16px left padding showing clear hierarchy
Solution
Added CSS rules for
[data-level="sub"]attribute selector intask-list-view.css:The TypeScript code was already setting
data-level="sub"on sub-header elements, but the corresponding CSS rules only existed in the Bases-specific stylesheet. This PR adds the missing rules to the general TaskList view styles.