[codex] fix main CI regressions#524
Open
blove wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0716128 to
d626aa0
Compare
d626aa0 to
9ad14c2
Compare
9ad14c2 to
b8e875e
Compare
b8e875e to
d778277
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ngaf/chatand remove provider license checks from MIT packages (@ngaf/langgraph,@ngaf/render).@ngaf/licensingpeer declarations from MIT packages that do not call licensing (@ngaf/langgraph,@ngaf/render,@ngaf/ag-ui).Root Cause
The post-merge main CI failures covered two separate regressions:
website:e2eclicked the first submit button on/pricing, which now belongs to a Stripe checkout form before the lead form. That triggered/api/checkout/sessionwithoutSTRIPE_SECRET_KEY.langgraph:test --coveragefailed in a license-check test for@ngaf/langgraph, but@ngaf/langgraphis MIT-licensed. The better fix is to remove license checks from MIT packages instead of preserving stale license-test coverage outside@ngaf/chat.Validation
PATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx test langgraph --skip-nx-cache -- --run src/lib/agent.provider.spec.ts --pool=forksPATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx test render --skip-nx-cache -- --run src/lib/provide-render.spec.ts --pool=forksPATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npm run generate-api-docsPATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx run-many -t lint --projects=chat,langgraph,ag-ui,render,a2ui,licensing,telemetryPATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx run-many -t test --projects=chat,langgraph,ag-ui,render,a2ui,licensing,telemetry --coveragePATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx run-many -t build --projects=chat,langgraph,ag-ui,render,a2ui,licensing,telemetry --configuration=productionPATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx e2e website --skip-nx-cache