Skip to content

[codex] fix main CI regressions#524

Open
blove wants to merge 1 commit into
mainfrom
codex/fix-main-ci-regressions
Open

[codex] fix main CI regressions#524
blove wants to merge 1 commit into
mainfrom
codex/fix-main-ci-regressions

Conversation

@blove
Copy link
Copy Markdown
Contributor

@blove blove commented May 21, 2026

Summary

  • Keep license enforcement in @ngaf/chat and remove provider license checks from MIT packages (@ngaf/langgraph, @ngaf/render).
  • Remove unnecessary @ngaf/licensing peer declarations from MIT packages that do not call licensing (@ngaf/langgraph, @ngaf/render, @ngaf/ag-ui).
  • Update generated API docs and narrative docs so Agent/Render no longer document license options.
  • Fix the pricing e2e validation test to target the lead form directly and fail clearly if it accidentally hits Stripe checkout.

Root Cause

The post-merge main CI failures covered two separate regressions:

  • website:e2e clicked the first submit button on /pricing, which now belongs to a Stripe checkout form before the lead form. That triggered /api/checkout/session without STRIPE_SECRET_KEY.
  • langgraph:test --coverage failed in a license-check test for @ngaf/langgraph, but @ngaf/langgraph is MIT-licensed. The better fix is to remove license checks from MIT packages instead of preserving stale license-test coverage outside @ngaf/chat.

Validation

  • PATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx test langgraph --skip-nx-cache -- --run src/lib/agent.provider.spec.ts --pool=forks
  • PATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx test render --skip-nx-cache -- --run src/lib/provide-render.spec.ts --pool=forks
  • PATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npm run generate-api-docs
  • PATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx run-many -t lint --projects=chat,langgraph,ag-ui,render,a2ui,licensing,telemetry
  • PATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx run-many -t test --projects=chat,langgraph,ag-ui,render,a2ui,licensing,telemetry --coverage
  • PATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx run-many -t build --projects=chat,langgraph,ag-ui,render,a2ui,licensing,telemetry --configuration=production
  • PATH=/tmp/codex-node22/bin:/tmp/codex-uv:$PATH npx nx e2e website --skip-nx-cache

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadplane Ready Ready Preview, Comment May 22, 2026 5:24pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant