Fix telemetry bugs and add chunk_and_submit_genpipes wrapper#76
Merged
Conversation
paulstretenowich
commented
Jun 10, 2026
paulstretenowich
commented
Collaborator
- Fix $LOG_MD5 not expanding in wget call (single vs double quotes in common.py)
- Fix SUBMIT_RETCODE initialized to 1 causing telemetry skip on re-runs
- Add chunk_and_submit_genpipes.sh wrapper and register it in tools.py
- shellcheck and code quality fixes across chunk/submit scripts
- Fix $LOG_MD5 not expanding in wget call (single vs double quotes in common.py) - Fix SUBMIT_RETCODE initialized to 1 causing telemetry skip on re-runs - Add chunk_and_submit_genpipes.sh wrapper and register it in tools.py - shellcheck and code quality fixes across chunk/submit scripts
MareikeJaniak
approved these changes
Jun 10, 2026
MareikeJaniak
left a comment
MareikeJaniak
left a comment
Collaborator
There was a problem hiding this comment.
We can update the cit script to reflect the updates and test more widely.
| LOG_MD5=$(echo $USER-'{unique_identifier}' | md5sum | awk '{{ print $1 }}') | ||
| if test -t 1; then ncolors=$(tput colors); if test -n "$ncolors" && test $ncolors -ge 8; then bold="$(tput bold)"; normal="$(tput sgr0)"; yellow="$(tput setaf 3)"; fi; fi | ||
| wget --quiet '{server}?{request}&md5=$LOG_MD5' -O /dev/null || echo "${{bold}}${{yellow}}Warning:${{normal}}${{yellow}} Genpipes ran successfully but was not send telemetry to https://bigbrother.c3g-app.sd4h.ca. This error will not affect genpipes jobs you have submitted.${{normal}}" | ||
| wget --quiet "{server}?{request}&md5=$LOG_MD5" -O /dev/null || echo "${{bold}}${{yellow}}Warning:${{normal}}${{yellow}} Genpipes ran successfully but was not send telemetry to https://bigbrother.c3g-app.sd4h.ca. This error will not affect genpipes jobs you have submitted.${{normal}}" |
Collaborator
There was a problem hiding this comment.
Minor thing, but it should probably say "but has not sent telemetry"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.