fix(release): group multi-scope commits and exclude scoped types in changelog#260
Merged
Merged
Conversation
The changelog group regexps used `[[:word:]-]+` for the commit scope, which excludes commas, so multi-scope commits like `fix(cli,server,store):` fell through to "Others" instead of "Bug Fixes". The exclude filters (`^docs:` etc.) likewise matched only unscoped commits, leaking `docs(...)`/`chore(...)` into the changelog. Allow commas in the group scope class and match an optional scope in the exclude filters. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The goreleaser changelog mis-categorized commits in the v0.26.0 release: the
headline
fix(cli,server,store): honor remote device filterslanded underOthers instead of Bug Fixes, and scoped
docs(...)/chore(...)commits leaked into the changelog instead of being excluded.
Two root causes in
.goreleaser.yaml:[[:word:]-]+for the commit scope, which does notmatch commas — so multi-scope commits like
fix(cli,server,store):failedthe Features/Bug Fixes patterns and fell through to Others. Single-scope
commits (
fix(panel):) matched fine, which is why prior releases lookedcorrect.
^docs:,^test:,^chore:,^ci:) matched onlyunscoped commits, so
docs(proto):,chore(deps):, etc. were neverexcluded.
Changes
[[:word:]-]+→[[:word:],-]+.^docs:→^docs(\([^)]+\))?!?:(and the same fortest/chore/ci).Validation
goreleaser check— config is valid (the only reported issue is apre-existing
homebrew_casks.binarydeprecation, unrelated to this change).using Go's
regexp(the same RE2 engine goreleaser uses). All casesclassify correctly: multi-scope
fix(a,b,c):→ Bug Fixes, single-scopestill works,
fix:/fix(a,b)!:handled, scopeddocs/chore/ci/testexcluded, merge commits excluded,
refactor/perf→ Others.Affects future releases only; the v0.26.0 notes are already published and
unchanged.