fix(p3): use async lower result pointer from params trail#1486
Open
andreiltd wants to merge 1 commit into
Open
fix(p3): use async lower result pointer from params trail#1486andreiltd wants to merge 1 commit into
andreiltd wants to merge 1 commit into
Conversation
Async canonical lower appends a result pointer to flat params when
flat_results is non-empty. The async task metadata was treating the
first raw param as the result pointer, which corrupts params for async
imports that have both params and results.
The relevant spec snippet is this:
```
case 'lower':
if len(flat_params) > MAX_FLAT_ASYNC_PARAMS:
flat_params = [opts.memory.ptr_type()]
if len(flat_results) > 0:
flat_params += [opts.memory.ptr_type()]
flat_results = ['i32']
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async canonical lower appends a result pointer to flat params when flat_results is non-empty. The async task metadata was treating the first raw param as the result pointer, which corrupts params for async imports that have both params and results.
The relevant spec snippet is this:
case 'lower': if len(flat_params) > MAX_FLAT_ASYNC_PARAMS: flat_params = [opts.memory.ptr_type()] if len(flat_results) > 0: flat_params += [opts.memory.ptr_type()] flat_results = ['i32']