fix: call exercism by absolute path in install_exercism#54
Merged
Conversation
`exercism upgrade` failed on a fresh install because ~/.local/bin
(where the binary was just installed) isn't on PATH within install.sh's
own process — it's only added by init_private_paths in a new shell:
./install.sh: line 202: exercism: command not found
Invoke it by absolute path. Found by re-running install.sh in a fresh
ubuntu:24.04 container.
Fixes #51
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
install_exercismrunsexercism upgraderight after installing the binary to~/.local/bin/exercism, but~/.local/binisn't on PATH withininstall.sh's own process (it's only added byinit_private_pathsin a new shell). On a first install:The binary still installs (3.5.8); only the self-
upgradeis skipped — but it's a spurious error on every fresh install.Fix
Found by re-running
install.shin a freshubuntu:24.04container.Fixes #51
🤖 Generated with Claude Code