fix: point init_node PATH at $PNPM_HOME/bin#53
Merged
Conversation
pnpm v11 installs its binary and global tools into $PNPM_HOME/bin, but init_node added $PNPM_HOME to PATH, so pnpm/node/bats/http-server/ netlify/fkill were never on PATH in a shell despite installing correctly. Use $PNPM_HOME/bin, matching what pnpm's own installer writes to ~/.bashrc. Shell-side counterpart to the Makefile fix in #48. Found by re-running install.sh in a fresh ubuntu:24.04 container. Fixes #52 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
init_nodeadded$PNPM_HOMEto PATH:But pnpm v11 installs its binary and all global tools into
$PNPM_HOME/bin. So after a successful install, a login shell's PATH had the wrong dir and none of pnpm/node/bats/http-server/netlify/fkill were on PATH despite installing correctly (binaries confirmed in~/.local/share/pnpm/bin/). This is the shell-side counterpart to the Makefile fix in #48.Fix
Matches what pnpm's own installer writes to
~/.bashrc. Found by re-runninginstall.shin a freshubuntu:24.04container.Fixes #52
🤖 Generated with Claude Code