fix: put jenv on PATH in install_java before using it#46
Merged
Conversation
install_java cloned jenv to ~/.jenv via `make ~/.jenv` but never added
~/.jenv/bin to PATH within the script, so the following calls failed:
install.sh: line 129: jenv: command not found
install.sh: line 130: jenv: command not found
The JDK + Maven still installed via apt, but jenv was never configured
(no version registered, no global set). Export ~/.jenv/bin and run
`jenv init` before `jenv add`/`jenv global`. Found by running install.sh
in a fresh ubuntu:24.04 container.
Fixes #42
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
install_javaclones jenv to~/.jenv(viamake ~/.jenv) but never adds~/.jenv/binto PATH in the running script, so the subsequent calls fail:The JDK + Maven still install via apt, but jenv is never configured — no version registered, no global set.
~/.jenv/binonly reaches PATH later viainit_javain a new shell.Fix
Found by running the full
install.shin a freshubuntu:24.04container (#42).Fixes #42
🤖 Generated with Claude Code