build(cmake): use nlohmann/json git submodule#27
Open
ShashwatAgrawal20 wants to merge 1 commit into
Open
Conversation
Vendors nlohmann/json at v3.12.0 under backend/external/json so builds no longer need a network download for the dependency. Closes builder-inc#23.
ShashwatAgrawal20
requested review from
Shobhit-Nagpal and
kayareyouokay
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend/external/jsonas a git submodule (same pattern as uWebSockets).add_subdirectory(external/json)instead of FetchContent tarball download, so configure no longer needs network access for this dependency.Closes #23.
Test plan
cmake -S backend -B backend/buildcmake --build backend/build --target tests websocket_server./backend/build/tests— 12/12 passed