Skip to content
This repository was archived by the owner on May 29, 2025. It is now read-only.

Add function to show public holiday result#159

Open
KevCui wants to merge 6 commits into
bugswriter:mainfrom
KevCui:main
Open

Add function to show public holiday result#159
KevCui wants to merge 6 commits into
bugswriter:mainfrom
KevCui:main

Conversation

@KevCui

@KevCui KevCui commented Feb 28, 2021

Copy link
Copy Markdown

No description provided.

@sudocanttype

sudocanttype commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

Nice. Can you write some test cases for it and send the testoutputs.txt? Or if you don't want to, I can make a new PR with the testcases.

@sudocanttype

Copy link
Copy Markdown
Contributor

K I made a pr to your main for testing. @KevCui

added testing for public holidays
@KevCui

KevCui commented Mar 1, 2021

Copy link
Copy Markdown
Author

Thanks @sudocanttype 👍

@sudocanttype

Copy link
Copy Markdown
Contributor

output.txt
Proof that it works. If someone else wants to test before we merge in, go for it

@sudocanttype

Copy link
Copy Markdown
Contributor

@BeyondMagic Can you test this branch and see if it works for you? If it does, i think this is ready to merge

@BeyondMagic

Copy link
Copy Markdown
Contributor

I think Basic Answers has conflict with Public Holidays, Public Holidays should be put before it.

@sudocanttype

Copy link
Copy Markdown
Contributor

Can you give me an example of where it conflicts? I need something to test to fix the problem

@BeyondMagic

Copy link
Copy Markdown
Contributor

try "christmas" with both features

@sudocanttype

Copy link
Copy Markdown
Contributor

oh yea, i see it

@BeyondMagic

BeyondMagic commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

also, I think we can add a better sed there, like

holiday's name
* holiday's day
holiday's name
* holiday's day
...

or

holiday's name - holiday's day
holiday's name - holiday's day
holiday's name - holiday's day
...

@sudocanttype

Copy link
Copy Markdown
Contributor

what exactly is ./tuxi christmas supposed to return? are we trying to give the definition?

@BeyondMagic

Copy link
Copy Markdown
Contributor

I mean, it should, but it's not.

@sudocanttype

Copy link
Copy Markdown
Contributor

This doesnt seem to be a problem with the public holiday function. Try checking out the main branch of tuxi and trying ./tuxi christmas. For me it still returns the same thing, so something else is messing with it

@BeyondMagic

Copy link
Copy Markdown
Contributor

Oh yeah, I remember fixing this in develop branch, I thought this would fix this too in the main since the name is for public holidays

@sudocanttype

Copy link
Copy Markdown
Contributor

How did you fix it in the develop branch?

@BeyondMagic

Copy link
Copy Markdown
Contributor

by adding -a to see all results, lol

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants