fix(tui): add fleet refresh spinner and tracing spans#4376
Merged
Conversation
- Bump workspace version 0.21.1 → 0.21.2 - Consolidate duplicate CHANGELOG.md section headers in [0.21.2] - Update splash snapshot for new version string - Update test badge count (9824) - Update specs to reflect changes since v0.21.1
fleet_poll_task now sends AgentEvent::Status("Refreshing fleet...")
before the DB call and clears it on both success and error paths,
satisfying the TUI rule that all background operations must show
a visible spinner.
start_session and end_session in fleet_session.rs gain
#[tracing::instrument] attributes, making fleet lifecycle events
visible in local Chrome traces and Jaeger.
Closes #4369
Closes #4366
github-actions
Bot
added
documentation
github-actions
Bot
added
bug
github-actions
Bot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fleet_poll_taskinsrc/tui_bridge.rsnow sendsAgentEvent::Status("Refreshing fleet...")before thelist_agent_sessionsDB call and clears the status on both success and error paths, fixing the silent background poll that violated the TUI spinner rule.start_sessionandend_sessioninsrc/fleet_session.rsgain#[tracing::instrument]attributes, making fleet session lifecycle events visible in local Chrome traces and Jaeger.Test plan
cargo nextest run --workspace --lib --bins)cargo clippy --workspace -- -D warnings— 0 warningsbackend = "local"):fleet.session.startandfleet.session.endspans visible in trace JSONCloses #4369
Closes #4366