Skip to content

Jump to Active Service#1040

Merged
ffrose merged 16 commits into
buerokratt:devfrom
1AhmedYasser:Jump-to-Active-Service
Jun 8, 2026
Merged

Jump to Active Service#1040
ffrose merged 16 commits into
buerokratt:devfrom
1AhmedYasser:Jump-to-Active-Service

Conversation

@1AhmedYasser

Copy link
Copy Markdown
Collaborator

@matKlju matKlju linked an issue May 28, 2026 that may be closed by this pull request
8 tasks
@matKlju matKlju requested a review from trevorling June 1, 2026 08:58

interface JumpToServiceInputBuilderProps {
seedGroup: Assign[];
onChange: (group: Assign[]) => void;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly for these

interface JumpToServiceInputElementProps {
element: Assign;
onRemove?: (id: string) => void;
onChange: (element: Assign) => void;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly for these

import JumpToServiceInputBuilder from './JumpToServiceInputBuilder';
import PreviousVariables from './PreviousVariables';

type ServiceOption = { name: string; serviceId: string };

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly for these

type FormSelectProps = SelectHTMLAttributes<HTMLSelectElement> & {
type SelectOption<T = string> = {
label: string;
value: T;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly for these

Comment thread GUI/src/types/jump-to-service.ts Outdated
export interface JumpToService {
serviceName: string;
serviceId?: string;
input: Assign[];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly for these

@1AhmedYasser 1AhmedYasser requested a review from trevorling June 2, 2026 14:50
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@ffrose ffrose merged commit e759e2a into buerokratt:dev Jun 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jump to Active Service

3 participants