Fix SonarCloud reliability issues across monorepo#206
Open
sirdeggen wants to merge 1 commit into
Open
Conversation
Fix 166 reliability findings: Number.NaN/Number.parseInt, codePointAt, new Array(), replaceAll, Math.trunc, [[ ]] shell tests, plus genuine logic fixes (Hash.ts loop counter, message-box-server mutable export, ts-p2p async constructor, sort comparators, unreachable code). Patch-bump @bsv/sdk, @bsv/teranode-listener, @bsv/uhrp-lite, @bsv/uhrp-storage-server.
sirdeggen
requested review from
BraydenLangley,
tonesnotes and
ty-everett
as code owners
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
NaN→Number.NaN,parseInt/isNaN→Number.*,charCodeAt→codePointAt,Array(n)→new Array(n), global.replace→.replaceAll,x | 0→Math.trunc(x), shell[ ]→[[ ]]Hash.tsloop-counter reassignment (S2310);message-box-servermutableletexport → const container (S6861, no external consumers);ts-p2pasync-in-constructor →startupPromise+ready()(S7059, auto-start preserved); sort comparators (S2871); unreachable code (S1763); identical branches (S3923); empty-Map test (S4158); ARIA attrs inSearchBox.tsxHash.tssurrogate-paircharCodeAt, benchmark| 032-bit RNG coercion, generated asyncapi HTML, minified vendor CSS, live/manual test stubs@bsv/sdk2.1.6,@bsv/teranode-listener1.0.5,@bsv/uhrp-lite0.1.4,@bsv/uhrp-storage-server0.2.5 (own version field only; lockfile untouched)Test plan
@bsv/sdksuite green (1142 passed locally incl. Hash/DRBG)@bsv/wallet-toolboxsuite green (manual/live tests compile-only)