fix(release): drop cross-ref/infra rewrites from #203, keep only version bumps#204
Merged
Merged
Conversation
…tch bumps PR #203 ran sync-versions, which rewrote 45 cross-package dep ranges (e.g. ^2.1.4 -> ^2.1.5) and patch-bumped 7 infra components. Those caret ranges already satisfied check-versions against the new local versions, so the rewrites were unnecessary — and they forced pnpm-lock.yaml to re-resolve against registry versions that are not yet published (gasp 1.2.4, sdk 2.1.5, ...), breaking `pnpm install --frozen-lockfile` on main. Revert every cross-ref and infra change; retain only the 9 package own-version patch bumps (the actual release intent). Own-version fields are not recorded in the lockfile importers, so the lockfile stays valid. check-versions: clean. pnpm install --frozen-lockfile: exit 0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirdeggen
requested review from
BraydenLangley,
tonesnotes and
ty-everett
as code owners
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #203 ran
sync-versions, which (beyond the intended own-version patch bumps) rewrote 45 cross-package dep ranges and patch-bumped 7 infra components. Those caret ranges (e.g.^2.1.4) already satisfiedcheck-versionsagainst the new local versions, so the rewrites were unnecessary — and they forcedpnpm-lock.yamlto re-resolve against registry versions not yet published (gasp 1.2.4, sdk 2.1.5, ...). Result:pnpm install --frozen-lockfilefails onmain(ERR_PNPM_OUTDATED_LOCKFILE).Fix
Revert every cross-ref and infra change. Retain only the 9 package own-version patch bumps — the actual release intent:
@bsv/overlay-topics→ 1.0.2@bsv/wallet-toolbox(+client, +mobile) → 2.1.29@bsv/verifast→ 0.1.1@bsv/overlay→ 2.0.4@bsv/overlay-express→ 2.3.1@bsv/sdk→ 2.1.5@bsv/gasp→ 1.2.4Own-version fields are not recorded in lockfile importers, so the lockfile stays valid.
Verification
node scripts/check-versions.mjs→ cleanpnpm install --frozen-lockfile→ exit 0🤖 Generated with Claude Code