Skip to content

🎨 Palette: [UX improvement] Add proper ARIA controls and dynamic ID to PPP savings expand toggle - #355

Open
brycejohnson1417 wants to merge 1 commit into
mainfrom
palette/ppp-savings-accordion-aria-10208604153617379123
Open

🎨 Palette: [UX improvement] Add proper ARIA controls and dynamic ID to PPP savings expand toggle#355
brycejohnson1417 wants to merge 1 commit into
mainfrom
palette/ppp-savings-accordion-aria-10208604153617379123

Conversation

@brycejohnson1417

Copy link
Copy Markdown
Owner
  • 💡 What: Added useId to generate a dynamic contentId and added aria-controls={contentId} to the expand/collapse toggle. Added id={contentId} to both branch elements of the conditional rendering.
  • 🎯 Why: Screen reader association was broken for the expanding content section. Adding aria-controls explicitly links the trigger button to the dynamically rendered content panels. Using useId() ensures unique IDs if the component is reused.
  • 📸 Before/After: Visuals are unchanged. Semantic relationships have been established in the DOM.
  • ♿ Accessibility: Fixes accordion accessibility by providing an unbroken screen reader association using a dynamically generated unique ID.

PR created automatically by Jules for task 10208604153617379123 started by @brycejohnson1417

…o PPP savings expand toggle

Added useId to generate a dynamic contentId and added aria-controls to the expand/collapse toggle. Added id={contentId} to both branch elements of the conditional rendering.

This ensures screen reader association remains unbroken for the expanding content section. Adding aria-controls explicitly links the trigger button to the dynamically rendered content panels. Using useId() ensures unique IDs if the component is reused.

Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
map-app-supabase Ready Ready Preview, Comment Jul 7, 2026 10:28am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant