Skip to content

馃帹 Palette: [UX improvement] Add ARIA labels to custom switch components #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brycejohnson1417 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

馃帹 Palette: [UX improvement] Add ARIA labels to custom switch components #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-07-06 - Missing ARIA Labels on Switch Toggles
**Learning:** Custom toggle switches (`role="switch"`) used in the UI, even if they have descriptive text nearby, must explicitly include an `aria-label` (or `aria-labelledby`) for proper screen reader support. The visual context does not automatically translate to the interactive element without it.
**Action:** Ensure all custom toggle switches explicitly provide an `aria-label` attribute if they do not contain embedded visible text.
2 changes: 2 additions & 0 deletions components/fraternitees/fraternitees-portal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ function PluginToggle({
type="button"
role="switch"
aria-checked={enabled}
aria-label={`Toggle ${label}`}
disabled={disabled}
onClick={onToggle}
className={classNames(
Expand Down Expand Up @@ -1038,6 +1039,7 @@ export function FraterniteesWorkspace({
type="button"
role="switch"
aria-checked={dailyAutoSync.enabled}
aria-label="Toggle daily sync"
onClick={() => void updateDailyAutoSync(!dailyAutoSync.enabled)}
className={classNames(
"relative h-7 w-12 shrink-0 rounded-full border transition",
Expand Down
Loading