⚡ Bolt: [performance improvement] Bypass redundant database calls in tenant resolution - #352
Conversation
Refactored `resolveTenantAccess` to use the synchronous `compileWorkspaceExperience` instead of `getWorkspaceExperienceBySlug` when the `Organization` object has already been fetched (e.g., from memberships or email domains). This eliminates redundant N+1-like database queries. Also made `selectMembershipOrganization` generic to safely preserve and pass down the full `Organization` type. Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Optimized
resolveTenantAccessto bypass redundantgetWorkspaceExperienceBySlugcalls by using the synchronouscompileWorkspaceExperiencewhen theOrganizationis already fetched. Also madeselectMembershipOrganizationgeneric to safely preserve theOrganizationtype.🎯 Why:
resolveTenantAccessfrequently already has the fullOrganizationobject (e.g. fromlistByIdsfor memberships orfindFirstByWorkspaceEmailDomain). Passing the slug togetWorkspaceExperienceBySlugforces another unnecessary database query to fetch the same organization.📊 Impact: Eliminates 1 unnecessary database lookup during tenant resolution for authenticated users, speeding up session validation.
🔬 Measurement: Verify changes pass
npm run test:tenant-access-selectionandnode scripts/check-tenant-provider-isolation.mjs.PR created automatically by Jules for task 10567363460154625903 started by @brycejohnson1417